Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEVICE_TIMEOUT parameter and show packet lost error #129

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 18, 2020

No description provided.

@at-wat at-wat self-assigned this Mar 18, 2020
@at-wat at-wat requested a review from seiga-k March 18, 2020 04:57
@at-wat
Copy link
Member Author

at-wat commented Mar 18, 2020

@seiga-k please take a look.

@at-wat at-wat changed the title Add DEVICE_TIMEOUT parameter Add DEVICE_TIMEOUT parameter and show packet lost error Mar 18, 2020
Copy link

@seiga-k seiga-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the default value, but it not the main topic, so I approved this PR.

if (timeout_us == 0)
{
// Default timeout before loading parameter file.
timeout_us = 200000;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the default value different from the parameter's default value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep the PC's read timeout value same as before this PR.

@at-wat at-wat merged commit ffc9c14 into master Mar 18, 2020
@at-wat at-wat deleted the add-device-timeout-param branch March 18, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants